dev/core#1973 Fix Email & Phone storage issues in event location

[eileenmcnaughton]

Overview

Fixes a fairly old regression whereby updating event location fields doesn't work properly

Before

Email - Second field value cannot be saved on form submit.
To replicate -

Navigate to Event -> Location tab - https://dmaster.demo.civicrm.org/civicrm/event/manage/location?reset=1&action=update&id=3

Enter a value for the second email field and save. The second field is empty after the form is submitted. And Email2 value is displayed on the first email field

Phone: Every time the Location form is submitted, a new row is inserted in phone table even if it already exist.
To replicate -

Navigate to Event -> Location tab - https://dmaster.demo.civicrm.org/civicrm/event/manage/location?reset=1&action=update&id=3

Fill both the phone numbers and save.
Re-save the form without changing any value. 2 new duplicate rows have been inserted in civicrm_phone table.
This happens on every submission of the Location form.

After

Should update ok - hopefully without breaking @yashodha's use case from
#13534

Technical Details

I wanted to go further on the cleanup but the approach to do that depends on https://lab.civicrm.org/dev/core/-/issues/2044

Comments

https://lab.civicrm.org/dev/core/-/issues/1973

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jitendrapurohit]

Have tested both the issues mentioned in https://lab.civicrm.org/dev/core/-/issues/1973. Thanks @eileenmcnaughton for the fix 👍. Email and Phones values are saved as expected after this patch.

[eileenmcnaughton]

@colemanw

[colemanw]

I'm happy with the code, test & review by @jitendrapurohit

[yashodha]

@eileenmcnaughton looks good, thanks!

[eileenmcnaughton]

@yashodha did you test your original issue is still fixed ? Might be worth it