[REF] Simplify array construction #18432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In trying to interpret civicrm#17992 I realised that the code copies values from the dao to an array, copies the array to another array, unsets most of the variables and then uses that second array. This simplifies. The easiest way to work through this code is in a debugger running testProcessMembershipUpdateStatus
|
(Standard links)
|
|
Yep, that was strange. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] Simplify array construction
Before
$memberParams defined, then copied to $memParams, then most keys unset, then used
After
define the keys that are used....
Technical Details
In trying to interpret #17992
I realised that the code copies values from the dao to an array, copies the array
to another array, unsets most of the variables and then uses that second array.
This simplifies.
The easiest way to work through this code is in a debugger running
testProcessMembershipUpdateStatus
Comments