Buttonrama

[agh1]

Overview

This combines PRs #18005 and #18087 into one monstrosity. This follows the decision to revert both late in the 5.29 beta cycle and merge them early in the 5.31 alpha cycle to maximize exposure before the release.

Before / After

See #18005 for a thorough comparison of the visual changes. In addition, pretty much all instances of <input type="submit"> are now <button type="submit">. A <button> element has contents, while an <input> of the type "submit" or "button" displays the plain-text value of the value attribute. The result is that we can treat real buttons the same way as links and other things that are made to look and act like buttons.

Comments

The commits are those from #18005 followed by #18087. A couple of spots had to be fixed to accommodated changes in the meantime. Finally, there's a commit to remove obsolete OpenFlashChart code that I noticed when updating JS references.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Excellent work @agh1 !
I'll merge this now to maximize exposure before release.

[agileware-justin]

For anyone following this, there is some really useful updating documentation shared on Mattermost here, https://chat.civicrm.org/civicrm/pl/a79bgp6ir7ypiyp8sgjzi93nwa

[eileenmcnaughton]

@jamienovick - one of the reasons we reverted this from 5.29 & re-merged to 5.31 was to give more leadtime for shoreditch. This will go out in 6 weeks now and a fix needs to be done in shoreditch to make the buttons look right again with this merged.