Switch to cached/non-deprecated membership type functions

[mattwire]

Overview

Initial run to see if tests pass.

There are quite a few functions to basically get the same information - some make direct calls to the database while others used cached functions. It will probably makes sense to supersede all these with an API4 call in the future but moving most of them to a single (cached) function is a good first step!

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

9 failures - example:

CRM_Core_BAO_ActionScheduleTest::testInheritedMembershipPermissions
Failure in api call for relationship create:  explode() expects parameter 2 to be string, array given

[mattwire]

Last commit failing with Failure in api call for Membership create: explode() expects parameter 2 to be string, array given on:

api_v3_ContactTest.testMergeOrganizations
api_v3_JobTest.testProcessMembershipUpdateStatus
api_v3_MembershipTest.testCreateWithRelationship
api_v3_MembershipTest.testCreateWithSpouseRelationship
api_v3_RelationshipTest.testCreateRelatedMembership with data set "APIv3"
CRM_Contact_BAO_RelationshipTest.testSingleMembershipForTwoRelationships
CRM_Core_BAO_ActionScheduleTest.testInheritedMembershipPermissions
CRM_Member_BAO_MembershipTest.testDeleteRelatedMembershipsOnParentTypeChanged
CRM_Member_BAO_MembershipTest.testMembershipUpdateDoesNotDeleteRelatedMembershipsByMistake
CRM_Member_Form_MembershipTest.testFormRulePermanentOverrideWithNoStatus
CRM_Member_Form_MembershipTest.testFormRuleUntilDateOverrideWithValidOverrideEndDate
CRM_Member_Form_MembershipTest.testFormRuleFixedJoin6MonthsAgo
CRM_Member_Form_MembershipTest.testTwoInheritedMembershipsViaPriceSetInBackend

[mattwire]

Closing as will be submitting each commit separately, my ref MJW_1458