Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#1980 Add v4 api LineItem entity #18388

Merged
merged 1 commit into from
Sep 10, 2020
Merged

dev/core#1980 Add v4 api LineItem entity #18388

merged 1 commit into from
Sep 10, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 6, 2020 •
edited
Loading

Overview

Adds apiv4 LineItem entity

Before

nada

After

Voila!

Technical Details

Comments

@civibot
Copy link

civibot bot commented Sep 6, 2020

(Standard links)

@civibot civibot bot added the master label Sep 6, 2020
@eileenmcnaughton eileenmcnaughton changed the title Add v4 api LineItem entity dev/core#1980 Add v4 api LineItem entity Sep 6, 2020
@seamuslee001
Copy link
Contributor

Test fails relate

@eileenmcnaughton eileenmcnaughton mentioned this pull request Sep 7, 2020
Merged
@eileenmcnaughton
Copy link
Contributor Author

test fixes flushed out #18395

@eileenmcnaughton eileenmcnaughton force-pushed the line4 branch 2 times, most recently from 020d25d to b90489e Compare September 7, 2020 02:50
@eileenmcnaughton
Copy link
Contributor Author

Tests still failing in #18395 but I think #18365 removes the hacky set up that a bunch are failing on. Once merged I'll reconsider it

@mattwire
Copy link
Contributor

mattwire commented Sep 7, 2020

Test fails relate

@eileenmcnaughton
Copy link
Contributor Author

I'm going to close this for now because it's blocked until I can resolve the test failures - which #18395 would fix, if working - but it needs #18365

I don't want to clog up the review queue with PRs that are not reviewable so I'll re-open this when the blocking-issues are solved

@seamuslee001
Copy link
Contributor

@eileenmcnaughton needs a rebase

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 I'm there!

@eileenmcnaughton
Copy link
Contributor Author

Woot - it finally passed

@colemanw colemanw merged commit fe31661 into civicrm:master Sep 10, 2020
@eileenmcnaughton eileenmcnaughton deleted the line4 branch September 10, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eileenmcnaughton @seamuslee001 @mattwire @colemanw