Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try catch to main loops on core ipn classes #18384

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 6, 2020

Overview

Add try-catch blocks to help move away from repetitive error handling

when viewed as

https://github.com/civicrm/civicrm-core/pull/18384/files?w=1 it's not that scary

Before

Unclear how exceptions are being handled

After

Clear try-catch, with a couple of examples

Technical Details

Comments

I'm a bit torn here - it seems PaypalExpress was just letting the exceptions bubble up to the top - I think we want to log them but maybe we should re-throw & kill the echos

@civibot
Copy link

civibot bot commented Sep 6, 2020

(Standard links)

@civibot civibot bot added the master label Sep 6, 2020
@eileenmcnaughton eileenmcnaughton force-pushed the validatepp branch 3 times, most recently from 4239732 to 78f3919 Compare September 6, 2020 04:25
@seamuslee001
Copy link
Contributor

Yeh I think this is fine merging

@seamuslee001 seamuslee001 merged commit 192c88f into civicrm:master Sep 6, 2020
@seamuslee001 seamuslee001 deleted the validatepp branch September 6, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants