dev/core#1921 Remove some places where the ghost of 2014 is getting special love #18359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per https://lab.civicrm.org/dev/core/-/issues/1921 we fixed the root cause of this 6 years ago....
|
(Standard links)
|
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 5, 2020
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 14, 2020
---------------------------------------- Same deal as civicrm#18359 Before ---------------------------------------- Casting to ISO date to avoid 2014 bug After ---------------------------------------- We are stuck in 2020 Technical Details ---------------------------------------- Comments ---------------------------------------- relevant tests api_v3_CaseTest::testCaseMerge
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Sep 14, 2020
Overview ---------------------------------------- Same deal as civicrm#18359 Before ---------------------------------------- Casting to ISO date to avoid 2014 bug After ---------------------------------------- We are stuck in 2020 Technical Details ---------------------------------------- Comments ---------------------------------------- relevant tests api_v3_CaseTest::testCaseMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup on dates
Before
to handle the fact that 6 years ago we needed to do this before using $dao->save()
After
It's a whole new world
Technical Details
per https://lab.civicrm.org/dev/core/-/issues/1921 we fixed the root cause of this 6 years ago....
Comments