[REF] Simplify logic on calling self::updateContributionStatus #18357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
self::updateContributionStatus is only called when contributionStatusId has been set - there is only one place that is set so move the code up there rather than set a param to trigger action further down
|
(Standard links)
|
eileenmcnaughton
commented
Sep 4, 2020
| @@ -268,7 +268,7 @@ public static function updatePendingOnlineContribution($participantId, $statusId | |||
| $contributionId = CRM_Contribute_BAO_Contribution::checkOnlinePendingContribution($participantId, | |||
| 'Event' | |||
| ); | |||
| if (!$contributionId) { | |||
| if (!$contributionId || !$participantId) { | |||
There was a problem hiding this comment.
I moved this up from lower down. It's actually impossible for it to be false but I thought I'd clarify that next round of cleanup by using type checking
eileenmcnaughton
force-pushed
the
fail
branch
from
7cfb5e3 to
560df63
Compare
|
test this please |
|
This looks fine to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code simplification
Before
First $contributionStatusId is set in exactly one place. Later it is the condition for calling self::updateContributionStatus
After
Call self::updateContributionStatus rather that using a variable as a 'note to self'
Technical Details
self::updateContributionStatus is only called when contributionStatusId has been set - there is only
one place that is set so move the code up there rather than set a param to trigger action further down
Comments