Fix customField legacy handling in APIv3 #18347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@colemanw grumpy tests |
colemanw
force-pushed
the
fixSerializeLegacy
branch
from
0e467ba to
e051ac1
Compare
colemanw
force-pushed
the
fixSerializeLegacy
branch
from
e051ac1 to
5e17e88
Compare
|
Grumpy brittle tests break with minor schema changes! |
|
I pulled this down & stepped through it in the tests & it seems to work & have good cover |
This was referenced Sep 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes dev/core#1996
Adds more shims to APIv3 for querying custom fields the old-school way.
Adds tests.
Before
Problem described in https://lab.civicrm.org/dev/core/-/issues/1996
After
Fixed, with tests.
Technical Details
Makes the
serializecolumn NOT NULL to make it simpler to use.