Fix dedupe regression whereby deleted contacts are found

[eileenmcnaughton]

Overview

Fixes a bug where deleted contacts are included in dedupe matches when permissions are applied.

Before

This can be replicated a few ways - the test uses

  $pairs = $this->callAPISuccess('Dedupe', 'getduplicates', [
      'rule_group_id' => 1,
      'check_permissions' => TRUE,
      'criteria' => ['Contact' => ['id' => ['>' => 1]]],
    ])['values'];

and included in the pairs are ones where one contact is deleted

After

Deleted contacts not treated as matches

Technical Details

This affects api calls where check_permissions = TRUE and getduplicates is called. This can be
done via the api (per this test) or ann easy UI way is with the deduper extension but it should
also affect the 'normal' dedupe screen.

Note that there can be cases where the dedupe results are cached into prevnext cache to hide this

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Test fails relate - I will check

[eileenmcnaughton]

test this please

[seamuslee001]

Test cover is good here and the changes make sense to me merge on pass