Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass-by-reference to recur function #18071

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 5, 2020

Overview

Do not pass-by-reference to recur function

Before

public function recur(&$input, &$ids, &$objects, $first) {

After

public function recur($input, $ids, $objects, $first) {

Technical Details

This is called once, from the main function and the values are not used again

Comments

This is called once, from the main function and the values are not used again
@civibot
Copy link

civibot bot commented Aug 5, 2020

(Standard links)

@civibot civibot bot added the master label Aug 5, 2020
@mattwire mattwire merged commit 57aa46f into civicrm:master Aug 5, 2020
@eileenmcnaughton eileenmcnaughton deleted the anet branch August 5, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants