Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove transaction from completeOrder signature #18046

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Remove transaction from completeOrder signature

Before

public static function completeOrder($input, &$ids, $objects, $transaction = NULL, $isPostPaymentCreate = FALSE) {

After

public static function completeOrder($input, &$ids, $objects, $isPostPaymentCreate = FALSE) {

Technical Details

It is no longer passed in

Screen Shot 2020-08-03 at 1 09 08 PM

Comments

We cleaned up the places that passed it prior

@civibot
Copy link

civibot bot commented Aug 3, 2020

(Standard links)

@civibot civibot bot added the master label Aug 3, 2020
@seamuslee001
Copy link
Contributor

Did a grep across the universe marking as merge on pass

@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit d40ae7d into civicrm:master Aug 3, 2020
@eileenmcnaughton eileenmcnaughton deleted the trans branch August 3, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants