Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PaypalIPN single function to not receive-by-reference #18044

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix PaypalIPN single function to not receive-by-reference

Before

public function single(&$input, &$ids, &$objects, $recur = FALSE, $first = FALSE) {

After

public function single($input, $ids, $objects, $recur = FALSE, $first = FALSE) {

Technical Details

The function is called from 2 places

  • main
  • recur

In both cases it is at the end of the function & so the vars, if altered, are not used again.
In the case of main they are internal to the function whereas for recur they are not returned to the
calling function (does not receive by reference)

Comments

The function is called from 2 places
- main
- recur

In both cases it is at the end of the function & so the vars, if altered, are not used again.
In the case of main they are internal to the function whereas for recur they are not returned to the
calling function
@civibot
Copy link

civibot bot commented Aug 2, 2020

(Standard links)

@civibot civibot bot added the master label Aug 2, 2020
@eileenmcnaughton
Copy link
Contributor Author

test this please

@mattwire mattwire merged commit a7a22b8 into civicrm:master Aug 3, 2020
@eileenmcnaughton eileenmcnaughton deleted the pprefs branch August 3, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants