Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing test #18036

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 2, 2020

Overview

Fix for failing test

Before

Test fails for much of the month as the join_date is in the past

After
cross fingers

Technical Details

BY ensuring join_date is in the past we get away from situations where there is no valid status

Comments

While it turns out #18034 passes I found it gets us into the rabbit hole of what should happen when an expired membership is renewed

What I found writing a test made my head hurt - so I figured I should fix it this way

BY ensuring join_date is in the past we get away from situations where there is no valid status
@civibot
Copy link

civibot bot commented Aug 2, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

I'm gonna self merge this so we can get the other tests to pass

@eileenmcnaughton eileenmcnaughton merged commit e0a5748 into civicrm:master Aug 2, 2020
@eileenmcnaughton eileenmcnaughton deleted the exp_test branch August 2, 2020 06:28
@demeritcowboy
Copy link
Contributor

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants