Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix for failing test
Before
Test fails for much of the month as the join_date is in the past
After
cross fingers
Technical Details
BY ensuring join_date is in the past we get away from situations where there is no valid status
Comments
While it turns out #18034 passes I found it gets us into the rabbit hole of what should happen when an expired membership is renewed
What I found writing a test made my head hurt - so I figured I should fix it this way