Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid use of crmMoney formatter #18031

Merged
merged 1 commit into from
Aug 1, 2020

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Aug 1, 2020

Overview

crmMoney smarty function is being used to "format" an html element instead of a monetary value.

Before

HTML element passed to crmMoney.

After

Not passed to crmMoney.

Technical Details

Comments

Identified while working on brick/money where this invalid use causes CRM_Utils_Money::format to throw an exception.

@civibot
Copy link

civibot bot commented Aug 1, 2020

(Standard links)

@civibot civibot bot added the master label Aug 1, 2020
@demeritcowboy
Copy link
Contributor

Looks good. Visited contribution page amounts tab and is same before and after. Something similar came up before.

There's even a line in Money::format() that says todo deprecate handling for the html tags because .... WTF.

Test fail is that unrelated stubborn one.

@eileenmcnaughton
Copy link
Contributor

Merging based on @demeritcowboy's review

@eileenmcnaughton eileenmcnaughton merged commit 9652b09 into civicrm:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants