Add testing to Authorize.net and remove the lines that are repeated

[eileenmcnaughton]

Overview

Removes transaction instantiation and later-duplicated lines of code from Authorize.net

Before

This adds tests to confirm that the status and modified date are updated & then removes the handling from A.net.

With these lines gone it's apparent that the transaction is not required here

After

transaction and duplicated lines removed

Technical Details

In Authorize.netIPN updates are made to the contributionRecur that are later made in ContributionRecur::updateOnNewPayment

This adds test cover to ensure no change and then removes them.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks fine to me

[eileenmcnaughton]

test this please

[seamuslee001]

@eileenmcnaughton style warnings

[seamuslee001]

Test fail unrelated