Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test framework] re-re-fix test and add test for test #18013

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

Thanks @eileenmcnaughton for the test update in #18009 - I didn't think of that and it makes sense. But in September it comes out as "2020-13-27" (on windows anyway).

Before

Test fix in #18009 addressed an issue in the previous test fix but added new issues.

After

Hopefully no more issues.

Technical Details

And in January the month string would be '5' without the leading 0.

Also the '+6 months' lower down needs a similar treatment.

Comments

Nothin' but test.

@civibot
Copy link

civibot bot commented Jul 31, 2020

(Standard links)

@civibot civibot bot added the master label Jul 31, 2020
@seamuslee001
Copy link
Contributor

Looks good to me

@seamuslee001 seamuslee001 merged commit d92281c into civicrm:master Jul 31, 2020
@eileenmcnaughton
Copy link
Contributor

@demeritcowboy nice test that whole membership calc dates needs a dataprovider test like this & a lot of simplification!

@demeritcowboy demeritcowboy deleted the fix-fix-test-test branch August 1, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants