Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove main PaymentExpress class #18010

Merged
merged 1 commit into from
Aug 1, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 31, 2020

Overview

Removes no-longer-working Payment Express processor class

Before

Now you see it

After

Now you don't

Technical Details

I recently identified that this processor had been broken for a long time & removed the broken IPN class - 7b3e290

At that time I didn't remove the main class as I was unsure how to deal with any legacy transactions related to it.

However, @mattwire pointed out he had done work earlier to make CiviCRM cope with not-present processor classes and,
on testing, I was unable to trigger any errors after setting up a contribution page & an event page & making a payment
and then deleting the class. I couldn't edit the contribution, but with appropriate in app messaging and no fatal
error.

Comments

I recently identified that this processor had been broken for a long time & removed the broken IPN class

At that time I didn't remove the main class as I was unsure how to deal with any legacy transactions related to it.

However, @mattwire pointed out he had done work earlier to make CiviCRM cope with not-present processor classes and,
on testing, I was unable to trigger any errors after setting up a contribution page & an event page & making a payment
and then deleting the class. I couldn't edit the contribution, but with appropriate in app messaging and no fatal
error.
@civibot
Copy link

civibot bot commented Jul 31, 2020

(Standard links)

@civibot civibot bot added the master label Jul 31, 2020
@mattwire
Copy link
Contributor

Is there any metadata or SQL files that need updating now this doesn't exist? Or did we already do that?

@eileenmcnaughton
Copy link
Contributor Author

@mattwire already done -I did a grep for PaymentExpress.

Looks like your earlier work paid off & made this easier than I expected

@mattwire
Copy link
Contributor

mattwire commented Aug 1, 2020

Cool!

@mattwire mattwire merged commit d73f979 into civicrm:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants