dev/core#1918 - Remove dubious qfkey checking code that never runs

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1918

This function has had a typo that caused the whole block except the last line to never get executed ever in the 10 years since it was added. If it was meant as security it's not secure, so have decided to remove it in the interest of simplicity. It would be just as easy to fix, but seems to have limited value to me if it hasn't run in 10 years and has no security purpose.

Technical Details

It generates an E_NOTICE because the strpos params are backwards, but it gets hidden.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I agree with your analysis.
OK without test since you can test something that does nothing & is being removed

[demeritcowboy]

Thanks!