Fix button name on updated form

[eileenmcnaughton]

Overview

Follow up on #17777 - rename buttong

Before

'Update Pending Status

After

Record payment'

Technical Details

Comments

Some slightly bigger changes we could make

1. add total_amount as a field to the row
2. add a payment for that amount, - either making it clear the email will only be sent if the payment completes the transaction, or sending a payment receipt in that case
3. don't limit to Pending & permit both positive and negative

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@agh1 you should probably give this a thumbs up since you are best placed to agree it

[agh1]

The words look good to me. We do have a tendency to capitalize all of the major words on a button. It's not what I'd do normally, but it is more-or-less a standard. It's also presumably used for multiple contributions. It's a thumbs-up for me if you capitalize the P and make it "Payments".

[agh1]

Separately, this and a few other PRs have this test failure on CRM_Contribute_BAO_ContributionRecurTest::testAutoRenewalWhenOneMemberIsDeceased and I know a certain someone who wrote a recently-merged PR affecting payment and contribution dates. @eileenmcnaughton do you think this might have been triggered by #17777, but if so, why wouldn't the test fail on that?

[agh1]

Oh it looks like the test might have been fixed by #18003

[eileenmcnaughton]

test this please

[agh1]

@eileenmcnaughton sorry I just realized this still says "Payment" rather than "Payments". In the context, I think there will nearly always be more than one contribution receiving payments.

[eileenmcnaughton]

@agh1 thanks - fixed

[eileenmcnaughton]

@seamuslee001 can you MOP

[eileenmcnaughton]

@seamuslee001 @colemanw let's merge this before the rc is cut

[seamuslee001]

Strange class name now but I think the new button name makes it more clear what is going on here merging