[REF] Reduce calls to CRM_Member_PseudoConstant::membershipType #17987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| $membershipType = CRM_Member_PseudoConstant::membershipType($entityObj->membership_type_id); | ||
| $subject = $membershipType ? $membershipType : ts('Membership'); | ||
|
|
||
| if (is_array($subject)) { |
There was a problem hiding this comment.
We can see in the line above this is not an array....
| $this->callAPISuccessGetSingle('Activity', [ | ||
| 'activity_type_id' => 'Membership Signup', | ||
| 'source_record_id' => $membershipID, | ||
| 'subject' => 'General - Payment - Status: test status', |
There was a problem hiding this comment.
This tests the altered lines
eileenmcnaughton
force-pushed
the
pseudo_mem
branch
2 times, most recently
from
94dbf49
to
0067191
Compare
1
Outdated
| @@ -0,0 +1,24 @@ | |||
| Reduce calls to CRM_Member_PseudoConstant::membershipType | |||
There was a problem hiding this comment.
@eileenmcnaughton please remove this file
There was a problem hiding this comment.
gone by lunchtime (yours, not mine)
| $subject = implode(", ", $subject); | ||
| } | ||
| $membershipType = CRM_Core_PseudoConstant::getLabel('CRM_Member_BAO_Membership', 'membership_type_id', $entityObj->membership_type_id); | ||
| $subject = $membershipType ?: ts('Membership'); |
There was a problem hiding this comment.
should this not be ??
There was a problem hiding this comment.
This is the same as
if ($membershipType) {
$membershipType;
}
else {
ts('Membership')
}
Whereas ?? is
if (isset($membershipType)) {
$membershipType;
}
else {
ts('Membership')
}
This function defaults to not using the cached version so that's a pretty good argument for making a more active effort to deprecate it. The createMembership function flushes it so we don't need to do that so much in tests now either. I also included swapping status over in the test
eileenmcnaughton
force-pushed
the
pseudo_mem
branch
from
0067191
to
a89e0a3
Compare
eileenmcnaughton
changed the title
|
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Switches code to use recommended function which, bonus, is cached
Before
After
Technical Details
This function defaults to not using the cached version so that's a pretty good argument for making a more
active effort to deprecate it. The createMembership function flushes it so we don't need to do that
so much in tests now either. I also included swapping status over in the test
Comments