dev/core#1909 - Avoid E_Notice on SMS provider form when no default url

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1909

Some providers, like the dummy SMS provider extension, don't provide a default url. The form gives an E_NOTICE when adding it as a provider.

Before

Before the patch, test gives: Undefined property: CiviTestSMSProvider::$_apiURL

After

No notice

Technical Details

Just needs check against missing parameter.

Comments

Has test

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks good to me MOP

[eileenmcnaughton]

test this please

[seamuslee001]

Test fail looks unrelated to me

[eileenmcnaughton]

I agree - I hit this on another PR today

[eileenmcnaughton]

CRM_Contribute_BAO_ContributionRecurTest.testAutoRenewalWhenOneMemberIsDeceased

[demeritcowboy]

Thanks!