[REF] Move handling of form elements back to the Form #17981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
merge_form
branch
from
66cb612 to
f84bb3c
Compare
This toxic function getRowsElementsAndInfo does things for the form layer but it's also heavily used in the BAO dedupeProcess. Ideally we want the things that are onnly being done to support (one specific) form to sit on that form. This does that just for one of the 2 arrays it creates of form elements. The rel_table_elements array is just an array that looks like [ ['checkbox', 'move_rel_contributions'], ['checkbox, 'move_rel_activities'], ] The rel_tables array is an array of metadata keyed by eg. move_rel_contributions. Ergo this can be done easily on the form layer with the data it already has
eileenmcnaughton
force-pushed
the
merge_form
branch
from
f84bb3c to
c813e8f
Compare
|
@JKingsnorth @pfigel any chance one of you could review? |
pfigel
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
(CiviCRM Review Template WORD-1.2)
- General standards
- (
r-explain) PASS - (
r-user) PASS: No user-visible change - (
r-doc) PASS - (
r-run) PASS: Tested that selected entities were still moved. Manually verified that it produces the same markup as before. Note: I did notice that deselecting the move options does not have an effect (i.e. contributions are moved regardless), but that doesn't appear to be caused by this PR. I'll file a separate issue.
- (
- Developer standards
|
Thanks @pfigel - appreciate it! |
|
Ditto thanks @pfigel for good review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup - move generation of an array required to add the checkboxes for 'Move related contributions' etc for the form back to the form
Before
After
No change - ie
Technical Details
This toxic function getRowsElementsAndInfo does things for the form layer but it's data also heavily used
in the BAO dedupeProcess. These are the only 2 places that call it
Ideally we want the things that are only being done to support (one specific) form
to sit on that form. This does that just for one of the 2 arrays it creates of form elements.
The rel_table_elements array is just an array that looks like
The rel_tables array is an array of metadata keyed by eg. move_rel_contributions.
Ergo this can be done easily on the form layer with the data it already has
Comments