[REF] Grant cleanup #17967
Merged
[REF] Grant cleanup #17967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a couple of things to cleanup the Grant BAO - 1) moves money handling back to the form layer 2) removes unnecessary date handling - the format that comes from the form layer is now supported by the BAO. I was looking to work on another but but then figured I needed a v4 api before writing the tests and then realised we shouldn't do a v4 api before getting rid of the legacy money handling. It does occur to me it might make more sense to start moving to an extension before doing any of the other steps
|
(Standard links)
|
|
Looks good, good to merge |
|
@eileenmcnaughton is this with an eye toward moving to a core extension? |
|
@colemanw I was originally looking to address a bug - but now suspect that might be a better first move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup
Before
Handling for 'cleaning' money fields in the BAO
After
Handling moved to the form layer, legacy date handling removed
Technical Details
This does a couple of things to cleanup the Grant BAO -
is now supported by the BAO.
I was looking to work on another but but then figured I needed a v4 api before
writing the tests and then realised we shouldn't do a v4 api before getting
rid of the legacy money handling.
It does occur to me it might make more sense to start moving to an
extension before doing any of the other steps
Comments