Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap multi record custom field inside a div #17966

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

pradpnayak
Copy link
Contributor

Overview

When a profile has multi-value custom field with 'Include in multi-record' checked, On profile edit mode the multi record listing appears at the bottom of the profile. Adding css or js for the section is difficult because its not wrapped inside a element. This PR wraps the whole html code inside a div with a class.

Before

Screen Shot 2020-07-27 at 00 06 24

After

Screen Shot 2020-07-27 at 00 05 33

@civibot
Copy link

civibot bot commented Jul 26, 2020

(Standard links)

@adevapp
Copy link

adevapp commented Jul 27, 2020

Have tested. Works as expected. Am able to assign CSS styling to multi record div now.

@eileenmcnaughton
Copy link
Contributor

Absent a clear-standard on this I think I'll go with 'seems harmless, let's merge'

ping @vingle @agh1

@eileenmcnaughton eileenmcnaughton merged commit 02b46eb into civicrm:master Aug 3, 2020
@pradpnayak pradpnayak deleted the divwrap branch September 10, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants