Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test framework] - Combine triplicate createCase functions #17957

Merged
merged 1 commit into from
Jul 25, 2020
Merged

[Test framework] - Combine triplicate createCase functions #17957

merged 1 commit into from
Jul 25, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

These are just copies of the same function.

There's one that uses a specific date so that tests can compare the results to a date, but otherwise they are copy/paste.

@civibot
Copy link

civibot bot commented Jul 25, 2020

(Standard links)

@civibot civibot bot added the master label Jul 25, 2020
@demeritcowboy
Copy link
Contributor Author

jenkins retest this please

@colemanw
Copy link
Member

Wow. 3 of them!

@demeritcowboy
Copy link
Contributor Author

demeritcowboy commented Jul 25, 2020 •
edited
Loading

Yep, and just ignore the git blame on the duplicates.

@demeritcowboy demeritcowboy changed the title [Test framework] - Combine duplicate createCase functions [Test framework] - Combine triplicate createCase functions Jul 25, 2020
@colemanw
Copy link
Member

Haha, well at least you get credit for cleaning them up.

@seamuslee001 seamuslee001 merged commit 3296183 into civicrm:master Jul 25, 2020
@demeritcowboy demeritcowboy deleted the combine-createcase branch July 25, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@demeritcowboy @colemanw @seamuslee001