Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove unnecessary complexity on im export #17949

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 24, 2020

Overview

This just removes a couple of lines that were already marked as being likely unhelpful. Because the impact of
these lines is tested the test needs tweaking too - but it only affects the name of the fields in the temp
table and in internal php keys

Before

Temp table column name and php key name non-standard for im & phone fields (but no impact seemingly for phone as the title is the same as the column)

After

Extra handling removed, standardised

Technical Details

This means the internal temp table columns are now 'im' (per the field name) not 'im_screen_name' per the field title. Likewise the keys. It is a simplification

Comments

Note the testExportIMData tests this within an inch of it's life

This just removes a couple of lines that were already marked as being likely unhelpful. Because the impact of
these lines is tested the test needs tweaking too - but it only affects the name of the fields in the temp
table and in internal php keys
@civibot
Copy link

civibot bot commented Jul 24, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

I've added has-test because I added exhaustive tests on this last round of cleanup in here

@colemanw
Copy link
Member

Ok I think we can trust the tests on this one.

@eileenmcnaughton eileenmcnaughton merged commit a5646ea into civicrm:master Jul 24, 2020
@eileenmcnaughton eileenmcnaughton deleted the export_im branch July 24, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants