[REF] Remove unnecessary complexity on im export #17949
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This just removes a couple of lines that were already marked as being likely unhelpful. Because the impact of
these lines is tested the test needs tweaking too - but it only affects the name of the fields in the temp
table and in internal php keys
Before
Temp table column name and php key name non-standard for im & phone fields (but no impact seemingly for phone as the title is the same as the column)
After
Extra handling removed, standardised
Technical Details
This means the internal temp table columns are now 'im' (per the field name) not 'im_screen_name' per the field title. Likewise the keys. It is a simplification
Comments
Note the testExportIMData tests this within an inch of it's life