Upgrade PEAR/mail_mime package to be compliant with PHP7.4 and deploy it using composer #17948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
mail_mime_upgrade
branch
from
74e25f2 to
d382e1d
Compare
seamuslee001
changed the title
|
Added has test as this is shown via the test failure to be at least hit by one of our unit tests |
… it using composer
seamuslee001
force-pushed
the
mail_mime_upgrade
branch
from
d382e1d to
968f619
Compare
|
ping @eileenmcnaughton @totten |
|
Wow - we were really out of date huh? And they still support php 5.0! Doesn't seem like many changes - I guess it's just low level support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This upgrades the Pear/mail_mime version from 1.10.2 to 1.10.9 the change logs are 1.10.9, 1.10.8, 1.10.7, 1.10.6, 1.10.5, 1.10.4, 1.10.3
Nothing jumps out at me as being problematic and also there is a unit test that failed on PHP7.4 https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=master,label=test-3/lastCompletedBuild/testReport/(root)/api_v3_JobTest/testMailReportForCsv/
Before
Test fails on PHP7.4
After
Test passes on PHP7.4