Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1905 Add configure icons on public pages #17942

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

jitendrapurohit
Copy link
Contributor

Overview

Add configure and priceset url icons on public contribution & event pages

Before

No Option to directly navigate to the configuration page or the priceset page used on the event or contribution

After

Configure and priceset icon is displayed on contribution and event pages.

Screenshot 2020-07-24 at 7 02 26 PM

Similarly for events.

image

Screenshot 2020-07-24 at 6 58 36 PM

Comments

Gitlab - https://lab.civicrm.org/dev/core/-/issues/1905

@civibot
Copy link

civibot bot commented Jul 24, 2020

(Standard links)

@civibot civibot bot added the master label Jul 24, 2020
@jitendrapurohit jitendrapurohit changed the title Add configure icons on public pages dev/core#1905 Add configure icons on public pages Jul 24, 2020
@eileenmcnaughton
Copy link
Contributor

@colemanw can you comment on this?

@eileenmcnaughton
Copy link
Contributor

this is very form layer so it doesn't need a a test. I'm still looking for a second opinion though. Perhaps if @colemanw doesn't get to it @agh1 or @MegaphoneJon might?

@homotechsual
Copy link
Contributor

Adding both is a bit much. Either button or Icon in my opinion. Not a deal breaker - it's good with me either way though!

@eileenmcnaughton
Copy link
Contributor

They configure different things...

@homotechsual
Copy link
Contributor

They configure different things...

Good to know, that may not be immediately obvious. Not sure how we'd clarify that...

@jitendrapurohit
Copy link
Contributor Author

If you hover on any icon/button the tooltip should be able to clarify. eg -

image

I think we do this on all the icons present on the page?

More related discussion is here - https://chat.civicrm.org/civicrm/pl/n3dzdtp9mf875kjzxc5pk3xmhh

@homotechsual
Copy link
Contributor

That's clear enough for me :-)

@eileenmcnaughton
Copy link
Contributor

OK - I'll go with @MikeyMJCO's review. I note there is a permission check so it's not showing for everyone & the code is straight forward

@eileenmcnaughton eileenmcnaughton merged commit 5720098 into civicrm:master Aug 4, 2020
agh1 added a commit to agh1/civicrm-core that referenced this pull request Aug 4, 2020
@agh1
Copy link
Contributor

agh1 commented Aug 4, 2020

Sorry I'm late to the party, but this PR wraps a lot of markup within {ts}. I opened #18064 to straighten that out and use Smarty helper functions to standardize this.

eileenmcnaughton added a commit that referenced this pull request Aug 4, 2020
dev/core#1905 rework #17942 with simpler ts strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants