Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error checking by-pass in tests #17940

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 24, 2020

Overview

Stop passing $abort to executeQuery within test - this parameter allows validation to be bypassed

Before

$abort = FALSE

After

$abort =TRUE

Technical Details

I think the param just exists because it's old code

Comments

@civibot
Copy link

civibot bot commented Jul 24, 2020

(Standard links)

@civibot civibot bot added the master label Jul 24, 2020
@colemanw
Copy link
Member

Test passes!

@colemanw colemanw merged commit 3ee4c3c into civicrm:master Jul 24, 2020
@colemanw colemanw deleted the abort branch July 24, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants