Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous opportunistic cache flush. #17936

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Removes a cache flush line that is not required as it has only just been flushed a few lines earlierr

Before

CRM_Contact_BAO_GroupContactCache::opportunisticCacheFlush();

After

poof

Technical Details

The opportunistic cache flush is already called by contact create and then again by each of the places
where the contact might be added to a group so this is just extraneous

Comments

@demeritcowboy this is what I mentioned on the dedupe one

The opportunistic cache flush is already called by contact create and then again by each of the places
where the contact might be added to a group so this is just extraneous
@civibot
Copy link

civibot bot commented Jul 24, 2020

(Standard links)

@civibot civibot bot added the master label Jul 24, 2020
@colemanw
Copy link
Member

Ok, I see where it's already happening as part of CRM_Contact_BAO_Contact_Utils::clearContactCaches().

@colemanw colemanw merged commit 2e5c996 into civicrm:master Jul 24, 2020
@colemanw colemanw deleted the cache branch July 24, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants