dev/core#1899 specify display mode for action links with icons

[agh1]

Overview

Changes in #17319 allow action links to be specified with icon to display the icon only instead of the link text. However, case activity action links have icons specified dating back to #14349 because they serve double-duty as specifying the buttons when viewing a single activity. This is a nice pattern to follow elsewhere in the future, but the result is that it forced the action links to render as icons only.

This allows the $iconMode to be set in CRM_Core_Action::formLink() in order to decide whether to display each action link as an icon (if specified), text, or both.

Before

Activity listing when viewing a case:

After

Technical Details

I set it so icon mode doesn't stash extra items under the "more >" both since there's more real estate and it just looks stupid. The screenshot below is what the same activity listing would appear as if it were in icon mode now (though it is not set this way as submitted):

Note that icon mode displays the text if there is no icon specified.

Comments

The only place where the links are displayed as icons is the edit payment link (a pencil) when viewing a contribution.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks I clicked around a bit on different types of screens and everything looks right.

[eileenmcnaughton]

@agh1 @demeritcowboy what version is affected by the regression - I think it was 5.27 so this needs to be on the rc?

[demeritcowboy]

Right good point.

[agh1]

@eileenmcnaughton RC PR is #17947 17947

[eileenmcnaughton]

Closing as merged via rc