dev/core#1902: "Contribution Source" profile field has no effect

[twomice]

This profile field has on the new contribution.

From the linked issue (dev/core#1902):

Overview

Profiles allow inclusion of the "Contributions :: Contribution Source" on contribution pages, but any value entered therein is disregarded when saving a new contribution.

Steps to reproduce (on dmaster.demo.civicrm.org)

Reproduction steps

1. Start with the Name and Address profile, and add to this profile the field "Contributions :: Contribution Source"
2. Add this profile to a Contribution Page, e.g., "Help Support CiviCRM!"
3. Open the Contribution Page, and fill in the form to submit an online contribution; for the Contribution Source field, enter a testable value such as "test source".
4. Submit the contribution
5. Find the contribution in CiviCRM, and open it; examine the value of the "Source" field.

Current behaviour

• The "Source" field reads "Online Contribution: Help Support CiviCRM!"

Expected behaviour

• The "Source" field should read "test source"

Environment information

The above repro steps were performed today on dmaster.demo.civicrm.org.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I gave this a light read & from a code point of view if slightly simplifies the code. It's not a high impact issue so I'm gonna let it sneak through without a test (especially since it could almost qualify as code cleanup). If it fixes it for you I'm Ok with it

[twomice]

Thanks @eileenmcnaughton !