[REF] Tighten up function signature for dedupePair #17923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This gets rid of the confusing keys earlier and ensures they are integers. It's only called from
one place (which is heavily tested) so the signature can be changed like this
Before
$dupes passed in but it only holds 2 poorly named parameters
After
Parameters passed in directly
Technical Details
I'm preparing to add an apiv4 function for this
Comments
Lots of tests cover this