Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Tighten up function signature for dedupePair #17923

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 23, 2020

Overview

This gets rid of the confusing keys earlier and ensures they are integers. It's only called from
one place (which is heavily tested) so the signature can be changed like this

Before

$dupes passed in but it only holds 2 poorly named parameters

After

Parameters passed in directly

Technical Details

I'm preparing to add an apiv4 function for this

Comments

Lots of tests cover this

This gets rid of the confusing keys earlier annd enaauures they are integers. It's only called from
one place (which is heavily tested) so the signature can be changed like this
@civibot
Copy link

civibot bot commented Jul 23, 2020

(Standard links)

@civibot civibot bot added the master label Jul 23, 2020
@eileenmcnaughton
Copy link
Contributor Author

@colemanw can you merge this - I was looking to add a v4 api for merge & this is preliminary cleanup

@seamuslee001
Copy link
Contributor

Tests would fail if this was a problem merging

@seamuslee001 seamuslee001 merged commit 580d386 into civicrm:master Jul 31, 2020
@seamuslee001 seamuslee001 deleted the dedupe_return branch July 31, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants