[REF] Minor function signature cleanup

[eileenmcnaughton]

Overview

Minor cleanup on GroupContact.create function signature

Before

$params passed by reference, $visibility received but just used to set $ignorePermissions

After

$params not by reference. Ditch interim 'visibility' param

Technical Details

$params is never altered so it is unnecessary to pass by reference.$ visibility is just
used to set ignorePermissions

Comments

Anything else you would like the reviewer to note

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I'm confused why this wasn't failing before - this is the code

    // Process group and tag
    if (!empty($fields['group'])) {
      $method = 'Admin';
      // this for sure means we are coming in via profile since i added it to fix
      // removing contacts from user groups -- lobo
      if ($visibility) {
        $method = 'Web';
      }
      CRM_Contact_BAO_GroupContact::create($params['group'], $contactID, $visibility, $method);
    }

so - the parameter $params['group'] is empty - but it always was - since the earlier check is on $fields['group'];

[eileenmcnaughton]

I switched ^^ to checking if $params['group'] is set

[colemanw]

Ok that all makes sense. I've followed up with #17928