Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sticky table header on "Find Activities" page #17917

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

christianwach
Copy link
Member

Overview

Fixes this issue on Lab.

The templates/CRM/Activity/Form/Selector.tpl template assigns the sticky class to the wrong element and therefore its sticky header is never initialised.

Before

No sticky table header on "Find Activities" page

After

Sticky table header on "Find Activities" page works as expected.

@civibot
Copy link

civibot bot commented Jul 22, 2020

(Standard links)

@civibot civibot bot added the master label Jul 22, 2020
@colemanw
Copy link
Member

Checked the existing code and can confirm this one is an outlier. All others apply the class to <thead>.

@colemanw colemanw merged commit 21b7b30 into civicrm:master Jul 22, 2020
@christianwach christianwach deleted the lab-core-1901 branch March 22, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants