dev/core#1846 Make DAO upgrade safe #17907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches api v3 and v4 to use that method so they are upgrade-safe by default.
The settingTest class was being too aggressive about creating and deleting domains, this teaches it to not delete pre-existing domains. Also marks an old unused api function deprecated.
|
(Standard links)
|
|
@seamuslee001 looks good. I did an Same site that had the issue as in https://lab.civicrm.org/dev/core/-/issues/1846#note_40672 Applied this PR to 5.27 Once applied, no fatal errors, and I can upgrade from 5.26.2 to 5.27 |
|
MOP based on @kcristiano r-run |
|
Thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This ports a9d0587 and #17729 to fix an upgrade issue where by extensions call Customfield.get as per backtrace on the lab ticket
ping @eileenmcnaughton @colemanw @kcristiano