dev/core#1894 - Make CRM_Activity_Form_SearchTest::testQill less time-sensitive

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/1894

This test has failed twice recently near GMT 00:00 on different PRs. It maybe doesn't come up that often but it can be made less time sensitive.

Technical Details

Dataproviders run at a different time and in a potentially different context than the actual test that uses them. If the provider runs and calculates something based on current time/day, and then the clock ticks past midnight before the actual test runs, the test might calculate a different time/day so it won't match.

Comments

Is test

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

The advantage of data providers is that it's not an all-or-nothing fail. But I agree that false fails is much more annoying

[demeritcowboy]

Good point. It could be done as a dataprovider using anonymous callbacks as the array elements which you then call from the test itself, it just seemed too fancy.

[eileenmcnaughton]

Yes - agree it might be overkill