Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Framework] - Tests for report downloads #17892

Merged
merged 1 commit into from
Jul 19, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

This is similar to the mail_report job tests in api/v3/JobTest, but it's for when you choose to export from the civireport actions dropdown. This tests that it does export the expected content, at least in the requested format since comparing the actual rows in something like a pdf is hard.

Before

Works

After

Works

Technical Details

I'm 50/50 on the use of runInSeparateProcess for the pdf one, but otherwise it complains about headers already being sent which is coming from dompdf. The same problem doesn't happen with csv because it calls a helper function which just calls the CMS to spool headers, and it doesn't get output until civiExit().

Comments

Is test.

@civibot
Copy link

civibot bot commented Jul 19, 2020

(Standard links)

@civibot civibot bot added the master label Jul 19, 2020
@totten
Copy link
Member

totten commented Jul 19, 2020

jenkins, test this please

@eileenmcnaughton eileenmcnaughton merged commit f7a322b into civicrm:master Jul 19, 2020
@demeritcowboy demeritcowboy deleted the tests-outputreport branch July 19, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants