Prevent session from starting during WordPress pseudo-cron procedures #17883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
added
the
merge ready
|
This looks good to me as well. Did an |
These functions were deemed unused in January and deprecation warnings were added at that point. Time to go
…ion" check Before ------ Suppose you install CiviCRM anew. The installer shows a bulleted list of things to do. One of those takes you to another, much longer list of things to do. And *then* there's a popup on the sidebar which says you need to "Complete Setup". You say to yourself, "I thought that's what I was doing!" But you click it anyway. That takes you to a page with another list of things to do, one of which is to "Complete Setup". The text and link clarify that "Complete Setup" actually means *set the name and address of the organization*. After ----- There are still several different pages telling you what to do after setup. But at least the label is more precise. :)
I was able to establish that this was accidentally broken five years ago with this commit civicrm@204c86d#diff-b00e65c9829c27da8b34e35f2e64d9b6L114 Resulting in the ipn url of http://dmaster.local/sites/all/modules/civicrm/extern/pxIPN.php?result=00003100032465271fc8c82d94ad434d&userid=Fuzion_Dev dying with the fatal error Uncaught Error: Call to undefined method CRM_Core_Payment_PaymentExpressIPN::singleton() in /Users/eileenmcnaughton/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Core/Payment/PaymentExpressIPN.php on line 391 This means we can be sure the ipn code does not work & hence can't be in use and can remove it. Can we remove the main class too? My thinking is that there could be old instances of the payment processor in people's installs and that if we remove or de-activate the payment processor instance it could cause other breakage. However, I think we could alter the processor type in the upgrade script to have CRM_Core_Manual as the class_name in place of 'Payment_PaymentExpress'
…g further discussion)
…hey are so they are validated before submit
…age template permissions
christianwach
force-pushed
the
lab-core-1889
branch
from
2094438
to
3ae20a8
Compare
|
Dammit, tried to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes this issue on Lab.
There is a linked PR on CiviCRM WordPress plugin.
Before
PHP warnings are written to the logs.
After
No PHP warnings are written to the logs.
Technical Details
There are a number of routes in WordPress that do not require sessions. Overloading the
sessionStart()method for WordPress means we can avoid doing so.