Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIv4 and pseudoconstants for RelationshipCache #17879

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

colemanw
Copy link
Member

Overview

Followup on the new RelationshipCache entity to add more metadata and an api + unit test.

@civibot
Copy link

civibot bot commented Jul 18, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@colemanw related fail

api\v4\Entity\RelationshipTest::testRelCache
API_Exception: Invalid field 'near_contact_id'

/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Query/Api4SelectQuery.php:474
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Query/Api4SelectQuery.php:356
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Query/Api4SelectQuery.php:334
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Query/Api4SelectQuery.php:321
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Query/Api4SelectQuery.php:230
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Query/Api4SelectQuery.php:114
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Query/Api4SelectQuery.php:129
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Generic/DAOGetAction.php:86
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Generic/DAOGetAction.php:74
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Provider/ActionObjectProvider.php:68
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/API/Kernel.php:150
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php:238
/home/jenkins/bknix-dfl/build/core-17879-579vu/web/sites/all/modules/civicrm/tests/phpunit/api/v4/Entity/RelationshipTest.php:46
/home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:615

@colemanw
Copy link
Member Author

@eileenmcnaughton @totten this is failing because #17734 didn't get merged :(
Therefore the test db is still '5.27.alpha1', therefore none of the new fields in civicrm_relationship_cache are visible to the api.

I could "fix" it in this PR by updating the test db to 5.29, but this is going to keep happening, and it's going to frustrate people when they can't figure out why tests seem to be failing for no reason.

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

I think an alternative got merged so hopefully this can pass now

@colemanw colemanw merged commit deabc29 into civicrm:master Jul 20, 2020
@eileenmcnaughton eileenmcnaughton deleted the relCacheApi branch July 20, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants