Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PrematureExit exception instead of weird hack in tests #17870

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Use PrematureExit exception instead of weird hack in tests #17870

merged 1 commit into from
Jul 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Passing is_unit_test to a function to avoid the civiExit routine has been superceded by catching
PrematureExitExceptions

Before

'is_unit_test' passed as a $_POST or $_GET

After

Catch the exception

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jul 16, 2020

(Standard links)

@civibot civibot bot added the master label Jul 16, 2020
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jul 16, 2020
Closed
@eileenmcnaughton
Use PrematureExit exception instead of weird hack in tests
a413c3d 
Passing is_unit_test to a function to avoid the civiExit routine has been superceded by catching
PrematureExitExceptions
@eileenmcnaughton eileenmcnaughton merged commit b687737 into civicrm:master Jul 17, 2020
@eileenmcnaughton eileenmcnaughton deleted the line branch July 17, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001