Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential js error on summary screen when reloading blocks #17865

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

colemanw
Copy link
Member

Overview

Fixes a possible edge-case js error on the summary screen when saving and reloading blocks.

Before

Possible error in rare cases where a dependent block has been altered by the layout editor to not support reloading.

After

If clause guards against errors.

@civibot
Copy link

civibot bot commented Jul 16, 2020

(Standard links)

@civibot civibot bot added the master label Jul 16, 2020
@eileenmcnaughton
Copy link
Contributor

This just adds a precautionary if so seems straight forward. No realistic way to test

@eileenmcnaughton eileenmcnaughton merged commit 87dacc5 into civicrm:master Jul 16, 2020
@eileenmcnaughton eileenmcnaughton deleted the summary branch July 16, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants