Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] ScheduledJob cleanup, remove unused var #17862

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 16, 2020

Overview

Does some minor cleanup to the ScheduledJob class, removing an unused function param.

Technical Details

Aside from removing the unused param, the rest is just whitespace & comment cleanup.

@civibot
Copy link

civibot bot commented Jul 16, 2020

(Standard links)

@civibot civibot bot added the master label Jul 16, 2020
@demeritcowboy
Copy link
Contributor

  • General standards
    • [r-explain] PASS
      • grep shows only one use with no param: CRM/Core/JobManager.php: $job->saveLastRun();
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS
      • Running job.execute works as expected and updates the last run. No obvious problems.
  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS
    • [r-maint] N/A
    • [r-test] PASS
      • Failing test is failing regularly lately.

@colemanw colemanw merged commit 1074b45 into civicrm:master Jul 16, 2020
@colemanw colemanw deleted the jobCleanup branch July 16, 2020 18:02
@colemanw
Copy link
Member Author

Thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants