dev/core#1090 Update extendedSerializeData to use the Backbone namesp… #17855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace to fix an issue with recent versions of elementor wordpress plugin
|
(Standard links)
|
|
@christianwach ping @seamuslee001 I'll test. can you identify the version and if it's the FOSS version or the Paid one? I do have copies of both :( |
|
Elementor v2.9.13 and non paid version |
|
Jenkins retest this please |
1 similar comment
|
Jenkins retest this please |
|
I have tested this patch on one of the staging site with Elementor installed. It works correctly. Approving this PR |
monishdeb
approved these changes
Jul 16, 2020
|
Too form-layer for a test. Test fail unrelated. I think this is OK given @seamuslee001 has confirmed FOSS issue & @monishdeb has tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ace to fix an issue with recent versions of elementor wordpress plugin
Overview
This doesn't aim to solve everything in the dec/core#1090 however i found a similar variant of that issue in that a client of ours uses the elementor plugin and after installing the latest version of the edit profile option on an Event or contribution on line registration section broke
Before
Cannot edit a profile from the online registration section of Event Registration config
After
Can edit a profile from the online registration section of event Regsitration configuration
ping @kcristiano