Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev/core#1879] .ical files not populating correctly for sites with ACL's configured for events #17852

Closed
wants to merge 1 commit into from

Conversation

alifrumin
Copy link
Contributor

@civibot
Copy link

civibot bot commented Jul 15, 2020

(Standard links)

@civibot civibot bot added the master label Jul 15, 2020
@alifrumin alifrumin changed the title WIP [dev/core#1879] .ical files not populating correctly for sites with ACL's configured for events [dev/core#1879] .ical files not populating correctly for sites with ACL's configured for events Jul 15, 2020
@demeritcowboy
Copy link
Contributor

Can you give a little more info on the details for setting up the ACL because I tried the patch and then logged in as a user in the group the ACL applied to, and then tried to download the ical and it was still mostly empty. Does it depend on specific ACL settings?

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

I'd feel better with a test.....

@alifrumin
Copy link
Contributor Author

alifrumin commented Jul 20, 2020

With this ACL (Everyone can edit the fall fundraiser):

acl

When logged in as an administrator with permissions to edit/view all events, ical files for events that do not have an ACL look like:

ical

even though this test event has a start and end date which should appear in the ical file.

That said, I believe any ACL for an event should work.

@eileenmcnaughton I will work on a test.

eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Aug 2, 2020
@eileenmcnaughton
Copy link
Contributor

@alifrumin I couldn't replicate this - but you might be able to build on #18038

seamuslee001 added a commit that referenced this pull request Aug 3, 2020
@alifrumin
Copy link
Contributor Author

Thank you @eileenmcnaughton!!!

@alifrumin
Copy link
Contributor Author

Closing in favor of Eileens fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants