[REF] Only printOnly once

[demeritcowboy]

Overview

It assigns printOnly twice.

Before

printOnly is assigned to the template first before being set to its proper value and then assigns it again later after.

After

Only printOnly once

Technical Details

Look down at line 2867. Also note the intervening lines might change its value, so it doesn't make sense to assign it before that.

Comments

This is part of a larger PR, so if you're thinking that if else block could be cleaned up it's coming later.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Looking at the code it's clear this line exists only to confuse (e.g this PR title!). Given the code does nothing it can't be tested :-)

[demeritcowboy]

Thanks!
For what it's worth there are some pending tests that indirectly test part of it.