Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Migrate Event Cart Setting into the Extension #17841

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

seamuslee001
Copy link
Contributor

Overview

This is a small follow on from #17743 which shifts the event cart setting into its' extension

Before

Event Cart setting part of normal Event Settings in core

After

Event Cart Setting in extension

ping @eileenmcnaughton @mattwire

@civibot
Copy link

civibot bot commented Jul 14, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

So once tests have completed I guess we need to go onto the test box & just check we can still enable this - and perhaps on an upgraded site too

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton yes I would say so but I would imagine if it works on the test site the only reason why it might not work on the upgrade is if for some reason the system hasn't installed the extension at which point other parts may break

@eileenmcnaughton
Copy link
Contributor

Added ok-without-test as this moving part need to be done before we can get jiggy with tests

@eileenmcnaughton
Copy link
Contributor

I just r-ran this on a new buildkit site & it works well - I was able to add to cart etc

@eileenmcnaughton eileenmcnaughton merged commit 4758366 into civicrm:master Jul 16, 2020
@eileenmcnaughton eileenmcnaughton deleted the eventcart_setting branch July 16, 2020 05:52
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 shall we aim to not do too much more on this until the rc is cut & try to get the queue down instead? Quite a few 'has-test' things...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants