dev/core#183 Use TempTable builder to generate table for import

[eileenmcnaughton]

Overview

Switches temp table handling to preferred methodology

Before

Used temp table builder

Technical Details

Replaces this change
https://github.com/civicrm/civicrm-core/pull/13633/files#diff-ca2efbe60fd40d921494640ad925df77R71

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

Test fails show this has specific relevant test cover on csv class & I added on sql class

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
    • Simple full import run works for both csv and sql.
• Developer standards
  • [r-tech] PASS
  • [r-code] Issue
    • Patch does not apply. Needs rebasing mostly because of the $Id$ parts. Jenkins test this please.
  • [r-maint] PASS with comment
    • The mapping creation line in the test I'm assuming is copy/paste and doesn't seem needed. Test runs correctly if I remove it.
  • [r-test] PASS

[eileenmcnaughton]

test this please

[demeritcowboy]

It needs rebasing because of the $Id$ parts.

[eileenmcnaughton]

ah thanks

[seamuslee001]

Merging as per @demeritcowboy 's review

[eileenmcnaughton]

@mfb not sure you saw this - I picked this out off your PR & I also fixed the strip numeric. As I mentioned I'm not sure there is much left from your PR except the install side of things which we should discuss with Tim