Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Undefined variable: jsSet in CRM_Core_BAO_Mapping::loadSavedMapping()' #17816

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

JKingsnorth
Copy link
Contributor

Overview

When editing smart group criteria built with 'Search builder':

Notice: Undefined variable: jsSet in CRM_Core_BAO_Mapping::loadSavedMapping() (line 952 of /var/aegir/platforms/alumni-staging/sites/alumni.staging.drupal.uis.cam.ac.uk/modules/contrib/civicrm/CRM/Core/BAO/Mapping.php).

Source: 5c322e1 (Ping @eileenmcnaughton

The variable forms part of the array that is returned, but it is not declared in some instances:

return [$mappingName, $defaults, $noneArray, $jsSet];

Before

jsSet might not be defined.

After

jsSet is always defined.

@civibot
Copy link

civibot bot commented Jul 13, 2020

(Standard links)

@civibot civibot bot added the master label Jul 13, 2020
@eileenmcnaughton eileenmcnaughton merged commit 60847be into civicrm:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants